This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
fix regression: MessageId having double brackets #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glensc
added a commit
to eventum/zend-mail
that referenced
this pull request
Jun 12, 2017
glensc
added a commit
to eventum/composer
that referenced
this pull request
Jun 12, 2017
samsonasik
reviewed
Jun 13, 2017
test/Header/MessageIdTest.php
Outdated
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| /** | |||
| * @group Zend_Mail | |||
| * @covers Zend\Mail\Header\MessageId<extended> | |||
| * @covers \Zend\Mail\Header\MessageId<extended> | |||
There was a problem hiding this comment.
for @Covers, already correct without \ prefix, revert it imo
There was a problem hiding this comment.
added it because phpstorm did not complete the class otherwise
There was a problem hiding this comment.
@asgrim no, @Covers doesn't need it, I use it in my tests without \ https://github.com/samsonasik/SanSessionToolbar/blob/master/test/Factory/Controller/SessionToolbarControllerFactoryTest.php#L81-L82 and it detect correctly
samsonasik
reviewed
Jun 13, 2017
test/Storage/MessageTest.php
Outdated
| @@ -20,7 +20,7 @@ | |||
|
|
|||
| /** | |||
| * @group Zend_Mail | |||
| * @covers Zend\Mail\Storage\Message<extended> | |||
| * @covers \Zend\Mail\Storage\Message<extended> | |||
There was a problem hiding this comment.
for @Covers, already correct without \ prefix, revert it imo
There was a problem hiding this comment.
added it for ide (phpstorm) to be able to resolve class
glensc
changed the title
glensc
force-pushed
the
message-id-brackets
branch
from
529dd85 to
6e17e96
Compare
this got broken from pull/86 when header lazyloading was omitted
glensc
force-pushed
the
message-id-brackets
branch
from
6e17e96 to
f1cb350
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this got broken from #86 when header lazyloading was omitted