Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

phpunit 6 #132

Merged
merged 3 commits into from
Mar 4, 2017
Merged

phpunit 6 #132

merged 3 commits into from
Mar 4, 2017

Conversation

kokspflanze
Copy link
Contributor

drop php 5.5
added phpunit 6 support
travis update

i will do the ::class job after that PR.

@Xerkus
Copy link
Member

Xerkus commented Mar 2, 2017

@kokspflanze please change branch to develop

@kokspflanze kokspflanze changed the base branch from master to develop March 2, 2017 21:24
@kokspflanze
Copy link
Contributor Author

@Xerkus done

Copy link
Member

@Xerkus Xerkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storage tests have setExpectedException that were not replaced with expectException.
Transport\NullTest expects exception that is not namespaced, might need to be changed too

@kokspflanze
Copy link
Contributor Author

@Xerkus ohh didnt saw them, these are skipped atm, so build say nothing=(

changed it=)

about the Transport\NullTest these is skipped because it doesnot work on php 7 (Cannot test Null transport under PHP 7; reserved keyword), so dont need to change it, also that namespace doesnt exist on phpunit 5.7.15, so if we change it we need for that the classname hack. i think that is not realy better as the the current solution.

@Xerkus
Copy link
Member

Xerkus commented Mar 4, 2017

grep, or its more modern alternative silversearcher, is your friend

@Xerkus Xerkus merged commit 5893f55 into zendframework:develop Mar 4, 2017
@Xerkus
Copy link
Member

Xerkus commented Mar 4, 2017

@kokspflanze thank you

@Xerkus Xerkus added this to the 2.8.0 milestone Mar 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants