Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Forwarded method flag in head request #480

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Middleware/ImplicitHeadMiddleware.php
Original file line number Diff line number Diff line change
@@ -43,6 +43,8 @@
*/
class ImplicitHeadMiddleware implements ServerMiddlewareInterface
{
const FORWARDED_HTTP_METHOD_ATTRIBUTE = 'forwarded_http_method';

/**
* @var null|ResponseInterface
*/
@@ -89,7 +91,9 @@ public function process(ServerRequestInterface $request, DelegateInterface $dele
}

$response = $delegate->process(
$request->withMethod(RequestMethod::METHOD_GET)
$request
->withMethod(RequestMethod::METHOD_GET)
->withAttribute(self::FORWARDED_HTTP_METHOD_ATTRIBUTE, RequestMethod::METHOD_HEAD)
);

return $response->withBody(new Stream('php://temp/', 'wb+'));
29 changes: 13 additions & 16 deletions test/Middleware/ImplicitHeadMiddlewareTest.php
Original file line number Diff line number Diff line change
@@ -14,8 +14,8 @@
use Prophecy\Argument;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\StreamInterface;
use Zend\Diactoros\Response;
use Zend\Diactoros\ServerRequest;
use Zend\Expressive\Middleware\ImplicitHeadMiddleware;
use Zend\Expressive\Router\Route;
use Zend\Expressive\Router\RouteResult;
@@ -162,26 +162,23 @@ public function testInvokesNextWhenRouteImplicitlySupportsHeadAndSupportsGet()
$result = $this->prophesize(RouteResult::class);
$result->getMatchedRoute()->will([$route, 'reveal']);

$request = $this->prophesize(ServerRequestInterface::class);
$request->getMethod()->willReturn(RequestMethod::METHOD_HEAD);
$request->getAttribute(RouteResult::class, false)->will([$result, 'reveal']);
$request->withMethod(RequestMethod::METHOD_GET)->will([$request, 'reveal']);
$request = (new ServerRequest([], [], null, RequestMethod::METHOD_HEAD))
->withAttribute(RouteResult::class, $result->reveal());

$response = $this->prophesize(ResponseInterface::class);
$response
->withBody(Argument::that(function ($body) {
$this->assertInstanceOf(StreamInterface::class, $body);
$this->assertEquals('', (string) $body);
return true;
}))
->will([$response, 'reveal']);
$response = new Response\JsonResponse(['some_data' => true], 400);

$delegate = $this->prophesize(DelegateInterface::class);
$delegate->process($request->reveal())->will([$response, 'reveal']);
$delegate->process(Argument::that(function (ServerRequestInterface $request) {
$attr = $request->getAttribute(ImplicitHeadMiddleware::FORWARDED_HTTP_METHOD_ATTRIBUTE);
$this->assertSame('HEAD', $attr);
return true;
}))->willReturn($response);

$middleware = new ImplicitHeadMiddleware();
$result = $middleware->process($request->reveal(), $delegate->reveal());
$result = $middleware->process($request, $delegate->reveal());

$this->assertSame($response->reveal(), $result);
$this->assertSame(400, $result->getStatusCode());
$this->assertSame('', (string) $result->getBody());
$this->assertSame('application/json', $result->getHeaderLine('content-type'));
}
}