This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Do not emit deprecation notices for 405 errors #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in zendframework#419, when using zend-stratigility 1.3 with Expressive 1.0, 405 errors are also now accompanied by deprecation notices. Since this is default functionality, we need to swallow those deprecation notices for now.
- Updated .docheader to no longer require `%date%` - Updated date range for updated files
A new method introduced in a maintenance release, and called by the whoops runner when invoked leads to breaking tests. We now test if that method exists, and, if so, mock it.
…tigility These versions have `Next` require stratigility request/response decorators internally; as such, the new test now creates those to pass to the route middleware.
| @@ -1,7 +1,7 @@ | |||
| <?php | |||
| /** | |||
| * @see https://github.com/zendframework/zend-expressive for the canonical source repository | |||
| * @copyright Copyright (c) 2016 Zend Technologies USA Inc. (http://www.zend.com) | |||
| * @copyright Copyright (c) 2016-2017 Zend Technologies USA Inc. (http://www.zend.com) | |||
There was a problem hiding this comment.
File is not changed, year shouldn't be then changed here. I hope we can do some auto checks on it, or at least some scripts to update it automatically - maybe on merge?
There was a problem hiding this comment.
For some reason, this one kept getting flagged until I changed the date range. I have no idea why, and I didn't want to waste more time on it.
| @@ -15,6 +15,7 @@ | |||
| use Psr\Http\Message\ResponseInterface; | |||
| use Psr\Http\Message\ServerRequestInterface; | |||
| use Psr\Http\Message\StreamInterface; | |||
| use ReflectionClass; | |||
There was a problem hiding this comment.
As this file is changed, year in header license notes should be updated to 2017.
There was a problem hiding this comment.
Thanks, updating now.
weierophinney
added a commit
that referenced
this pull request
Jan 9, 2017
weierophinney
added a commit
that referenced
this pull request
Jan 9, 2017
Forward port #420 Conflicts: CHANGELOG.md src/Application.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #419, when using zend-stratigility 1.3 with Expressive 1.0, 405 errors are also now accompanied by deprecation notices. Since this is default functionality, we need to swallow those deprecation notices for now.