This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Prevent deprecation notice based on triggering error middleware #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users cannot yet set the raiseThrowables flag, as there are not shipped facilities for handling errors using templates or whoops. As such, currently, if the queue is exhausted or an exception is thrown, error middleware is triggered. This patch adds an error handler to `Application::__invoke()` to swallow deprecation notices due to invocation of error middleware.
weierophinney
added a commit
that referenced
this pull request
Nov 11, 2016
weierophinney
added a commit
that referenced
this pull request
Nov 11, 2016
weierophinney
added a commit
that referenced
this pull request
Nov 11, 2016
Forward port #395 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users cannot yet set the raiseThrowables flag, as there are not shipped facilities for handling errors using templates or whoops. As such, currently, if the queue is exhausted or an exception is thrown, error middleware is triggered. This patch adds an error handler to
Application::__invoke()to swallow deprecation notices due to invocation of error middleware.