This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Specify that generateUri() MUST NOT encode returned URIs
#149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 of the 3 implementations we provide do not encode URIs (ZendRouter and FastRoute), and 3rd party utilities such as league/uri provide escaping capabilities at a fine-grained level. As such, this patch updates the interface to specify that implementations MUST NOT encode URIs returned by `generateUri()`. Additionally, the Aura router was updated to call `generateRaw()` internally to comply with the specification.
- Created a test to ensure that the AuraRouter is not encoding generated URIs.
weierophinney
added a commit
that referenced
this pull request
Oct 9, 2015
weierophinney
added a commit
that referenced
this pull request
Oct 9, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative to #134. The primary issue reported in that pull request was that the author wished to get the raw URL instead of the escaped version.
2 of the 3 implementations we provide do not encode URIs (ZendRouter and FastRoute), and 3rd party utilities such as league/uri provide escaping capabilities at a fine-grained level. As such, this patch updates the interface to specify that implementations MUST NOT encode URIs returned by
generateUri(). Additionally, the Aura router was updated to callgenerateRaw()internally to comply with the specification.