This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Route options not processed in ApplicationFactory #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
changed the title
|
Tests are not passing. I'll fix them and try to create some that cover this case. |
| @@ -17,6 +17,7 @@ | |||
| use Zend\Expressive\Exception; | |||
| use Zend\Expressive\Router\Aura as AuraRouter; | |||
| use Zend\Expressive\Router\RouterInterface; | |||
| use Zend\Expressive\Router\Route; | |||
There was a problem hiding this comment.
sort the use statement, place Zend\Expressive\Router\Route before Zend\Expressive\Router\RouterInterface
weierophinney
added a commit
that referenced
this pull request
Sep 3, 2015
Route options not processed in ApplicationFactory
weierophinney
added a commit
that referenced
this pull request
Sep 3, 2015
weierophinney
added a commit
that referenced
this pull request
Sep 3, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a route instance is created by calling
$app->route(...), that instance is automatically added to the router, which tries to process the route options.The problem is that the
ApplicationFactorysets the options after that, which makes the router ignore any option defined for the route.Creating the route as a new
Zend\Expressive\Router\Routeinstance and passing it to the$app->route(...)method after processing the options fixes this problem.