Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Properly detect PHP-DI container #265

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

holtkamp
Copy link

Provide a narrative description of what you are trying to accomplish:

  • Are you fixing a bug?

    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.
  • Are you creating a new feature?

    • Why is the new feature needed? What purpose does it serve?
    • How will users use the new feature?
    • Base your feature on the develop branch, and submit against that branch.
    • Add only one feature per pull request; split multiple features over multiple pull requests
    • Add tests for the new feature.
    • Add documentation for the new feature.
    • Add a CHANGELOG.md entry for the new feature.
  • Is this related to quality assurance?
    Completeness of support for PHP-DI as DI Container

  • Is this related to documentation?

@geerteltink geerteltink merged commit 6d4c49f into zendframework:master Nov 5, 2018
geerteltink added a commit that referenced this pull request Nov 5, 2018
Properly detect PHP-DI container
geerteltink added a commit that referenced this pull request Nov 5, 2018
geerteltink added a commit that referenced this pull request Nov 5, 2018
geerteltink added a commit that referenced this pull request Nov 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants