This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Added Swoole config, if installed #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geerteltink
suggested changes
Jun 17, 2018
config/config.php
Outdated
| // Swoole config to overwrite some services (if installed) | ||
| class_exists(\Zend\Expressive\Swoole\ConfigProvider::class) | ||
| ? \Zend\Expressive\Swoole\ConfigProvider::class | ||
| : null, |
There was a problem hiding this comment.
This doesn't seem to work: Zend\ConfigAggregator\InvalidConfigProviderException: Cannot read config from NULL - config provider must be callable.
|
@xtreamwayz you right, I fixed it. I didn't test without zend-expressive-swoole installed, thanks! |
|
To fix the Travis build you can append this to parameters:
ignoreErrors:
- '#Class Zend\\Expressive\\Swoole\\ConfigProvider not found#' |
|
@xtreamwayz thanks! |
geerteltink
approved these changes
Jun 19, 2018
geerteltink
added a commit
that referenced
this pull request
Jun 19, 2018
Added Swoole config, if installed
geerteltink
added a commit
that referenced
this pull request
Jun 19, 2018
geerteltink
added a commit
that referenced
this pull request
Jun 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support of Swoole overwriting some service configurations of zend-expressive.
The configuration is injected via
Zend\Expressive\Swoole\ConfigProviderif zend-expressive-swoole is installed.This PR allows to execute Swoole without any change on
public/index.php. We can just run the follows:To execute an Expressive application with Swoole.