Merge pull request #23 from webimpress/hotfix/descendant-selector

Descendant selector with spaces
zendframework · Apr 9, 2018 · 2209d79 · 2209d79
2 parents 3c63c60 + 63cc6a1
commit 2209d79
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/src/Document/Query.php b/src/Document/Query.php
@@ -100,7 +100,7 @@ function ($matches) use ($placeholder) {
         );
 
         $paths    = ['//'];
-        $path     = preg_replace('|\s+>\s+|', '>', $path);
+        $path     = preg_replace('|\s*>\s*|', '>', $path);
         $segments = preg_split('/\s+/', $path);
         $segments = str_replace($placeholder, ' ', $segments);
 

diff --git a/test/Document/QueryTest.php b/test/Document/QueryTest.php
@@ -134,13 +134,26 @@ public function testShouldAllowMatchingOfAttributeValues()
         $this->assertEquals("//tag[@id='id']//@attribute", $test);
     }
 
+    public function descendantSelector()
+    {
+        yield 'space before' => ['child >leaf'];
+        yield 'space after' => ['child> leaf'];
+        yield 'no spaces' => ['child>leaf'];
+        yield 'with spaces' => ['child > leaf'];
+        yield 'more spaces' => ['child   >   leaf'];
+    }
+
     /**
      * @group ZF-8006
+     *
+     * @dataProvider descendantSelector
+     *
+     * @param string $path
      */
-    public function testShouldAllowWhitespaceInDescendantSelectorExpressions()
+    public function testShouldAllowWhitespaceInDescendantSelectorExpressions($path)
     {
-        $test = Query::cssToXpath('child > leaf');
-        $this->assertEquals("//child/leaf", $test);
+        $test = Query::cssToXpath($path);
+        $this->assertEquals('//child/leaf', $test);
     }
 
     /**