This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Raise exception on serialization of Request object with emtpy HTTP me… #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzentota
force-pushed
the
serialization
branch
from
ef53922 to
295243c
Compare
|
LGTM. @weierophinney can be merged :). |
| )); | ||
| } | ||
| //HTTP uses a "<major>.<minor>" numbering scheme to indicate versions of the protocol | ||
| if (! preg_match('~^\d+\.\d+$~', $version)) { |
There was a problem hiding this comment.
HTTP/2 does not follow this format (see the HTTP/2 FAQ; no decimal point. I'll update this on merge.
weierophinney
added a commit
that referenced
this pull request
Mar 17, 2016
Raise exception on serialization of Request object with emtpy HTTP me…
weierophinney
added a commit
that referenced
this pull request
Mar 17, 2016
weierophinney
added a commit
that referenced
this pull request
Mar 17, 2016
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…thod