Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

[WIP] ServiceManager v2 + v3 compatibility #64

Closed
wants to merge 4 commits into from
Closed

[WIP] ServiceManager v2 + v3 compatibility #64

wants to merge 4 commits into from

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Jan 14, 2016

No description provided.

@ezimuel
Copy link
Contributor Author

ezimuel commented Jan 14, 2016

@weierophinney please review this PR, thanks!

@weierophinney weierophinney added this to the 2.6.0 milestone Jan 14, 2016
@weierophinney weierophinney self-assigned this Jan 14, 2016
weierophinney
weierophinney reviewed Jan 14, 2016
View reviewed changes
composer.json
"zendframework/zend-eventmanager": "dev-develop as 2.7.0"
"zendframework/zend-stdlib": "~2.7",
"zendframework/zend-servicemanager": "^2.7.3 || ^3.0",
"zendframework/zend-eventmanager": "^2.6.2 || ^3.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w00t! we can use tagged versions!

@weierophinney
Copy link
Member

@ezimuel Looks great!

Please add the .travis.yml changes as seen in the relevant zend-barcode PR so that we can validate that the code works properly with both v2 and v3 versions of the libraries going forward. After we get the results from that change, we'll know for certain if it's ready!

marc-mabe
marc-mabe reviewed Jan 16, 2016
View reviewed changes
src/PatternPluginManager.php
/**
* Don't share by default
*
* @var boolean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezimuel can you please write in the doc-block which property belongs to which service manager version as for me this looks like a mistake.

@marc-mabe
Copy link
Member

@ezimuel Why did you remove all PECL_INSTALL_* environment variables in.travis.yml`?

This was referenced Jan 16, 2016
Merged
Merged
This was referenced Jan 17, 2016
Closed
Merged
@marc-mabe
Copy link
Member

@ezimuel @weierophinney status ?

@kynx kynx mentioned this pull request Feb 6, 2016
Closed
@weierophinney weierophinney mentioned this pull request Feb 11, 2016
Merged
weierophinney added a commit that referenced this pull request Feb 11, 2016
@weierophinney
Added CHANGELOG for #64, #68, and #69
4def038
weierophinney added a commit that referenced this pull request Feb 11, 2016
@weierophinney
Merge branch 'feature/68' into develop
179da18 
Close #69
Close #68
Close #64
@weierophinney
Copy link
Member

Merged with #68 / #69 (which were rebased).

@weierophinney weierophinney mentioned this pull request Feb 11, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@weierophinney weierophinney

Labels
enhancement
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ezimuel @weierophinney @marc-mabe