This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
fixed seg fault in redis adapter on PHP 7 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After changing selected database on an already connected object the RedisResourceManager was again trying to connect which crashed.
|
To test added as the current tests reflected this seg fault already on PHP 7 |
marc-mabe
added a commit
that referenced
this pull request
Dec 22, 2015
fixed seg fault in redis adapter on PHP 7
marc-mabe
added a commit
that referenced
this pull request
Dec 22, 2015
marc-mabe
added a commit
that referenced
this pull request
Dec 22, 2015
marc-mabe
added a commit
that referenced
this pull request
Dec 22, 2015
|
Sorry little question, is a good practice self merge own PRs without any review? For me this PR is perfect :) But I don't know if its the correct flow. |
|
hi @gianarb, normally you are right! I did it only this time because it's a simple fix and it breaks very hard. It also breaks nearly all tests running on PHP 7 where it makes it very hard to find out if other changes are correct. Please tell me if I should avoid this practice in the future and/or what I can do if it doesn't get reviewed for a long time (which is sometimes the case here as this component requires a lot of setup to run). |
|
No problem for me :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After changing selected database on an already connected object
the
RedisResourceManagerwas again trying to connect which crashed.