This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Much better test coverage of AbstractAdapter #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-mabe
changed the title
| @@ -338,23 +348,6 @@ public function testInternalHasItemsCallsInternalHasItem() | |||
| $this->assertEquals(['key1'], $rs); | |||
| } | |||
|
|
|||
| public function testGetMetadataCallsInternalGetMetadata() | |||
There was a problem hiding this comment.
This gets tested by testGetMetadatas
|
The failed test is a real bug and will be fixed in #36 |
| @@ -416,6 +403,10 @@ public function simpleEventHandlingMethodDefinitions() | |||
|
|
|||
| ['decrementItem', 'internalDecrementItem', ['k', 1], true], | |||
| ['decrementItems', 'internalDecrementItems', [['k1' => 1, 'k2' => 2]], []], | |||
|
|
|||
| ['getCapabilities', 'internalGetCapabilities', [], new Capabilities( | |||
There was a problem hiding this comment.
I prefer create the object in a local var with a descriptive name so you can read the list of test cases quickly
|
I'll review this later |
marc-mabe
added a commit
that referenced
this pull request
Dec 20, 2015
Much better test coverage of AbstractAdapter
marc-mabe
added a commit
that referenced
this pull request
Dec 20, 2015
marc-mabe
added a commit
that referenced
this pull request
Dec 20, 2015
marc-mabe
added a commit
that referenced
this pull request
Dec 20, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't no why all of these lines were commented out. I think it was from initial writing the component as the tests where written for one of the very very first versions (before 2.0).
I have commented all these tests in and refactored the tests to the current version.