This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Create discrete namespaces for PSR-6/PSR-16 implementations #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates `Zend\Cache\Psr\CacheItemPool` and `Zend\Cache\Psr\SimpleCache` namespaces, moving class files for each implementation under the appropriate namespace.
Consistency in naming. Both standards implementations are _decorating_ a storage adapter.
7 tasks
weierophinney
added a commit
that referenced
this pull request
Apr 20, 2018
Also updates to detail the new namespaces of each implementation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per a suggestion from @marc-mabe, creates
Zend\Cache\Psr\CacheItemPoolandZend\Cache\Psr\SimpleCachenamespaces, moving class files for each implementation under the appropriate namespace.Additionally, renames
CachePoolItemAdaptertoCachePoolItemDecorator. Both standards implementations are decorating zend-cache storage adapters, so the entry points should use consistent naming, and not use the "adapter" terminology, which refers to the storage they are decorating to implement the standards.