Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

[BugFix] Using memcached on HHVM #15

Closed
wants to merge 1 commit into from

Conversation

rms230
Copy link
Contributor

@rms230 rms230 commented Jun 23, 2015

This fix is specificly for HHVM, when adding servers there is an undefined index error.

@Maks3w
Copy link
Member

Maks3w commented Jun 23, 2015

I think this needs a more in depth analisys.

  • There are more occurrences of addServers($servers)
  • May this should be done in the return of $resource->getServerList()

@Maks3w
Copy link
Member

Maks3w commented Jul 22, 2015

@rms230 I'll close this due inactivity.

@Maks3w Maks3w self-assigned this Jul 22, 2015
@Maks3w Maks3w closed this Jul 22, 2015
@gianarb
Copy link
Contributor

gianarb commented Jul 22, 2015

@Maks3w this closure's motivation is an internal role of @zendframework/community-review-team team? :)
Because into the ZF2 repo there are a lot of "inactive pr" 👍

@weierophinney
Copy link
Member

Re-opening. This corrects a number of issues on HHVM, bringing us closer to having the component work on that platform.

@weierophinney weierophinney reopened this Jul 22, 2015
weierophinney added a commit that referenced this pull request Jul 22, 2015
weierophinney added a commit that referenced this pull request Jul 22, 2015
@Maks3w
Copy link
Member

Maks3w commented Jul 22, 2015

@weierophinney Seriously?

@Maks3w
Copy link
Member

Maks3w commented Jul 22, 2015

I think this needs a more in depth analisys.

There are more occurrences of addServers($servers)
May this should be done in the return of $resource->getServerList()

@weierophinney
Copy link
Member

@Maks3w It's a start, which is far better than not taking it at all and leaving it completely uncorrected.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants