-
Notifications
You must be signed in to change notification settings - Fork 24
Add composer template #15
Changes from 1 commit
c8b7710
3e52d2c
06c9be1
fd0a29a
c069854
3cccb74
dbc5e12
b0a2fb4
d4d12cc
3ece15b
7a57a2e
dbfae78
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
{ | ||
"name": "zendframework/<project-name>", | ||
"description": "<project-description>", | ||
"homepage": "https://docs.zendframework.com/<project-name>/", | ||
"type": "library", | ||
"license": "BSD-3-Clause", | ||
"keywords": [ | ||
"http", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would replace these lines with a short description like: "keywords" : [
"<individual keywords for current project>"
], There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we should have here also |
||
"middleware", | ||
"psr", | ||
"psr-7", | ||
"psr-11" | ||
], | ||
"support": { | ||
"docs": "https://docs.zendframework.com/<project-name>/", | ||
"issues": "https://github.com/zendframework/<project-name>/issues", | ||
"source": "https://github.com/zendframework/<project-name>", | ||
"slack": "https://zendframework-slack.herokuapp.com", | ||
"forum": "https://discourse.zendframework.com" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we have here link to the main page of forum or maybe specific category there? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If a category exists, then we should use it. |
||
}, | ||
"extra": { | ||
"branch-alias": { | ||
"dev-master": "1.0-dev", | ||
"dev-develop": "2.0-dev" | ||
} | ||
}, | ||
"require": { | ||
"php": "^5.6 || ^7.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we change order also here, to have first There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't know. I think in every project it's the lowest PHP first at the moment. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For new packages, this will be simply |
||
}, | ||
"require-dev": { | ||
"phpunit/phpunit": "^6.0.8 || ^5.7.15", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would update these version to the latest: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree, however PHP Unit updates twice a month or so. It should not be the goal of this template to keep track of PHP Unit releases. |
||
"zendframework/zend-coding-standard": "~1.0.0" | ||
}, | ||
"autoload": { | ||
"psr-4": { | ||
"Zend\\<project-name>\\": "src/" | ||
} | ||
}, | ||
"autoload-dev": { | ||
"psr-4": { | ||
"ZendTest\\<project-name>\\": "test/" | ||
} | ||
}, | ||
"scripts": { | ||
"check": [ | ||
"@cs-check", | ||
"@test" | ||
], | ||
"upload-coverage": "coveralls -v", | ||
"cs-check": "phpcs", | ||
"cs-fix": "phpcbf", | ||
"test": "phpunit --colors=always", | ||
"test-coverage": "phpunit --coverage-clover clover.xml" | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add empty line at the end of the file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion: