chore: encourage use of node.js v20 and later releases #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veera
reviewed
Sep 10, 2024
package.json
Outdated
| @@ -35,7 +35,7 @@ | |||
| "yarn-audit-fix": "^9.3.1" | |||
| }, | |||
| "engines": { | |||
| "node": ">=18" | |||
| "node": ">=21" | |||
JeanMarcGoepfert
approved these changes
Sep 10, 2024
|
Can we please make sure that our developer documentation is updated here, since we call out the specific node version as a prerequisite. |
veera
approved these changes
Sep 11, 2024
anushkafka
changed the title
|
@zach-anthony Wow this is why people were expecting it to work for v16 even after we had already bumped it from 14 to 18 a in the past! Good catch 👍 |
anushkafka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
0a6552cUse node.js v21 and later releasesb40f194Update node-version & npmrc files37233d4Set a precedence in using node v20Detail
A quick QA of this branch in node v20.17.0
Checklist