Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-JIRA] Bump node from 14.17.3 to 20.13.1 #233

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

token-cjg
Copy link
Contributor

@token-cjg token-cjg commented Jun 25, 2024

Description

Let's use an up to date version of nodejs that is currently LTS

a9514ac Bump node from 14.17.3 to 20.13.1

Let's use an up to date version of nodejs that is currently LTS

5828f60 Ensure that zcli supports nodejs 18.x while it is in maintenance mode

  • Node 18 will be in maintenance mode until May 2026 [1], therefore we should
    not drop support

[1] https://endoflife.date/nodejs

Detail

Nodejs 14.17.3 is no longer supported, we should use a version of Nodejs that is supported. 20.13.1 seems like a reasonable choice.

Checklist

  • 💂‍♂️ includes new unit and functional tests

Let's use an up to date version of nodejs that is currently LTS
@token-cjg token-cjg force-pushed the cgoddard/no-jira/bump-node branch from 138ef49 to a9514ac Compare June 25, 2024 02:07
- Node 18 will be in maintenance mode until May 2026 [1], therefore we should
  not drop support

[1] https://endoflife.date/nodejs
@token-cjg token-cjg marked this pull request as ready for review June 25, 2024 03:13
@token-cjg token-cjg requested a review from a team as a code owner June 25, 2024 03:13
@token-cjg token-cjg merged commit 3b164da into master Jun 25, 2024
4 checks passed
@token-cjg token-cjg deleted the cgoddard/no-jira/bump-node branch June 25, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants