Zcli package ignore #142
Merged
Zcli package ignore #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code is working, tests seem to be working, but console.log() inside describe() function is not working.
Tests not running properly as .then() is not being run in package.test.ts
Functional testing working and Ignore feature is working and passing testing.
Added 'Configuration' subheading and moved app config information underneath it. Information on new .zcliignore feature is also included under this header.
anushkafka
reviewed
Nov 2, 2022
packages/zcli-apps/package.json
Outdated
| @@ -25,6 +25,7 @@ | |||
| "express": "^4.17.1", | |||
| "form-data": "^4.0.0", | |||
| "fs-extra": "^10.0.0", | |||
| "jszip": "^3.10.1", | |||
There was a problem hiding this comment.
Curious about the introduction of jszip to the project when we already have a similar package adm-zip here
There was a problem hiding this comment.
Thanks, I didn't noticed. Changed from jszip to adm-zip in recent push
zach-anthony
approved these changes
Nov 2, 2022
cl8au
reviewed
Nov 3, 2022
cl8au
reviewed
Nov 3, 2022
packages/zcli-apps/tests/functional/mocks/single_product_ignore/.zcliignore
Outdated
Show resolved
Hide resolved
cl8au
reviewed
Nov 3, 2022
packages/zcli-apps/tests/functional/mocks/single_product_ignore/manifest.json
Outdated
Show resolved
Hide resolved
Fixed a few nits, and changed code from using unnecessary additional 'jszip' package when zcli already uses 'adm-zip'.
|
We can delete |
etanxing
reviewed
Nov 4, 2022
Changed from jszip to pre-existing dependency adm-zip. Also changed from using .filter to .find in a case where only most recent object was needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZCLI package ignore
Description
Added support for developers to specify files/folders to be ignored as part of the packaging process as requested in this PR.
Detail
Patterns following the gitignore specification included in a .zcliignore file in the root directory for the app will be excluded from packaging when any of the above commands are executed
Checklist
Includes new functional testing to ensure files specified are not included in packaging process.
Updated apps.md with information on .zcliignore feature
References