Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP_ID as environment variable? #173

Closed
waclock opened this issue Mar 24, 2023 · 0 comments · Fixed by #254
Closed

APP_ID as environment variable? #173

waclock opened this issue Mar 24, 2023 · 0 comments · Fixed by #254
Labels
enhancement New feature or request

Comments

@waclock
Copy link

waclock commented Mar 24, 2023

Expectations

Our team has different zendesk instances and app IDs depending on the environment. In test, the app_id might be 123, and in production it could be 456.

We're using ENV variables in our CI/CD to automatically update apps, we were expecting APP_ID to be a variable as well so that we could dynamically set it without having to touch JSON files.

Reality

app_id is only read from zcli.apps.config.json, so we have to manually generate this file depending on the environment which is less ideal. Is there a reason this is the only variable that's not controllable by ENV variables?

@anushkafka anushkafka added the enhancement New feature or request label Jun 26, 2024
yoshdog added a commit that referenced this issue Aug 28, 2024
Someones we want to have seperate apps for staging and production. In these cases they will have a seperate app_id.

In this change we will allow users to set the `ZENDESK_APP_ID` environment variable to specify which app_id to use. This will allow developers to set this in their CICD pipelines.

Fixes: #173
anushkafka pushed a commit that referenced this issue Sep 3, 2024
…pps:update (#254)

* feat: add ability to use ZENDESK_APP_ID env var during apps:update

Someones we want to have seperate apps for staging and production. In these cases they will have a seperate app_id.

In this change we will allow users to set the `ZENDESK_APP_ID` environment variable to specify which app_id to use. This will allow developers to set this in their CICD pipelines.

Fixes: #173

* fix: type check

* fix: remove generated code

* fix: lints

* chore: add new unit test

* chore: update unit test

* fix: lints

* chore: reset mock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants