Skip to content

Commit

Permalink
fix: module resolution (#262)
Browse files Browse the repository at this point in the history
  • Loading branch information
yoshdog authored Sep 5, 2024
1 parent 33785c2 commit 12a08ce
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 3 deletions.
3 changes: 2 additions & 1 deletion packages/zcli-apps/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@
"rimraf": "^3.0.2",
"semver": "^7.3.2",
"tslib": "^2.4.0",
"uuid": "^8.3.2"
"uuid": "^8.3.2",
"@zendesk/zcli-core": "^1.0.0-beta.49"
},
"devDependencies": {
"@oclif/test": "=2.1.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/zcli-apps/src/commands/apps/update.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { getManifestFile } from '../../utils/manifest'
import { createAppPkg } from '../../lib/package'
import { Manifest, ZcliConfigFileContent } from '../../types'
import { validateAppPath } from '../../lib/appPath'
import { EnvVars } from '@zendesk/zcli-core/src/lib/env'
import { env } from '@zendesk/zcli-core'

export default class Update extends Command {
static description = 'updates an existing private app in the Zendesk products specified in the apps manifest file.'
Expand All @@ -20,7 +20,7 @@ export default class Update extends Command {
static strict = false

getAppID (appConfig: ZcliConfigFileContent) {
const app_id = process.env[EnvVars.APP_ID] || (appConfig ? appConfig.app_id : undefined)
const app_id = process.env[env.EnvVars.APP_ID] || (appConfig ? appConfig.app_id : undefined)
if (!app_id) { throw new CLIError(chalk.red('App ID not found')) }
return app_id
}
Expand Down
10 changes: 10 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1914,6 +1914,16 @@
resolved "https://registry.yarnpkg.com/@yarnpkg/lockfile/-/lockfile-1.1.0.tgz#e77a97fbd345b76d83245edcd17d393b1b41fb31"
integrity sha512-GpSwvyXOcOOlV70vbnzjj4fW5xW/FdUF6nQEt1ENy7m4ZCczi1+/buVUPAqmGfqznsORNFzUMjctTIp8a9tuCQ==

"@zendesk/zcli-core@*":
version "1.0.0-beta.49"
dependencies:
"@oclif/plugin-plugins" "=2.1.12"
axios "^1.7.5"
chalk "^4.1.2"
fs-extra "^10.1.0"
optionalDependencies:
keytar "^7.9.0"

JSONStream@^1.0.4:
version "1.3.5"
resolved "https://registry.yarnpkg.com/JSONStream/-/JSONStream-1.3.5.tgz#3208c1f08d3a4d99261ab64f92302bc15e111ca0"
Expand Down

0 comments on commit 12a08ce

Please sign in to comment.