Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade persistence to replace node_redis with ioredis #248

Merged
merged 11 commits into from
Oct 11, 2019
Merged

Upgrade persistence to replace node_redis with ioredis #248

merged 11 commits into from
Oct 11, 2019

Conversation

thomasbui93
Copy link
Contributor

@thomasbui93 thomasbui93 commented Oct 2, 2019 •
edited
Loading

Description

Replace redis client with ioredis to support reconnect and failover out of the box.
ioredis supports the following scenario out of the box:

  • Guarantees that the node you connected to is always a master even after a failover.
  • Auto-reconnect when Redis is down.
  • Better troubleshooting for error handling.

Risks

  • High: This is a breaking change. The version of persistence is bumped up to 2.0.0.
  • Rollback: Revert this PR or use the previous version.

@zendesk/radar

@thomasbui93 thomasbui93 force-pushed the kbui/replace-redis-with-ioredis branch from 2b04aa7 to 3fe64f4 Compare October 3, 2019 07:25
@thomasbui93 thomasbui93 changed the title WIP: Replace redis with ioredis Upgrade persistence to replace node_redis with ioredis Oct 3, 2019
@thomasbui93 thomasbui93 requested a review from a team October 3, 2019 13:17
niall3rs
niall3rs reviewed Oct 3, 2019
View reviewed changes
Copy link
Contributor

@niall3rs niall3rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Let's wait until Persistence is bumped to v2 to finalise

@thomasbui93 thomasbui93 requested a review from niall3rs October 11, 2019 09:42
@thomasbui93 thomasbui93 merged commit d71def0 into master Oct 11, 2019
@thomasbui93 thomasbui93 deleted the kbui/replace-redis-with-ioredis branch October 11, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niall3rs niall3rs niall3rs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasbui93 @niall3rs