Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower "type not found" log level from error -> warn #234

Merged
merged 1 commit into from
Jun 30, 2016

Conversation

junosuarez
Copy link
Contributor

@junosuarez junosuarez commented Jun 30, 2016

When a message refers to a resource that doesn't match any of the defined resource scope types, it's a client error, but the server can handle it just fine. We should still log it, since it might help investigating a client problem, but it is not a server error. This PR reduces log noise.

Also reformats message as string rather than additional param for better message

Required

  • 👍 from @zendesk/radar

Risks

  • None

@junosuarez junosuarez changed the title Type error as string rather than additional param for better message Lower "type not found" log level from error -> warn Jun 30, 2016
@vanchi-zendesk
Copy link
Contributor

👍

@junosuarez junosuarez merged commit 0d32726 into master Jun 30, 2016
@junosuarez junosuarez deleted the jden/type_error branch June 30, 2016 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants