Return Server#ready promise from Server#attach #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var radarServer = new Server() | ||
|
|
||
| var returned = radarServer.attach(httpServer, common.configuration) | ||
| expect(returned).to.equal(radarServer.ready) |
There was a problem hiding this comment.
Can we add a test that this promise gets resolved?
There was a problem hiding this comment.
Added a simple test for this- it's not doing a whole lot, but it was cheap and may help catch regressions.
|
👍 |
junosuarez
added a commit
that referenced
this pull request
Feb 17, 2016
…promise Return Server#ready promise from Server#attach
|
landed in 0.21.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the server ready promise from the Server.attach method
Required
Risks