Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable eslint in codeclimate #221

Merged
merged 1 commit into from
Feb 12, 2016
Merged

Disable eslint in codeclimate #221

merged 1 commit into from
Feb 12, 2016

Conversation

junosuarez
Copy link
Contributor

We use standard rather than eslint.
Currently we run it in a pretest step, so linting errors would be caught in a travisci build failure.
In the future, we may be able to move this linting step back into codeclimate.

References

Required

  • 👍 from @zendesk/radar

Risks

  • None, we lint using standard in our pretest npm script.

@junosuarez
Copy link
Contributor Author

Hmm, the build succeeded at https://codeclimate.com/github/zendesk/radar/builds/115. I think we need to remove and re-add the codeclimate integration in this repo's settings.

@vanchi-zendesk
Copy link
Contributor

👍

junosuarez added a commit that referenced this pull request Feb 12, 2016
@junosuarez junosuarez merged commit b76aec6 into master Feb 12, 2016
@junosuarez junosuarez deleted the jden/fix_codeclimate branch February 12, 2016 18:26
@junosuarez
Copy link
Contributor Author

landed in 0.21.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants