Further homepage re-styling #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes zencart#1246 I think we're closer now. The navbar headers of the `/user` and `/nav` pages mimic the hover colors of the originating cells on the homepage.
|
Just one tiny change and let's call it done - can you make the top nav a different color so it sticks out? Maybe #a8590f for example? |
Fixes zencart#1258 That's good, it's now contrast compliant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1246
I think we're closer now. The navbar headers of the
/userand/navpages mimic the hover colors of the relevant cells on the homepage.As @dbltoe mentioned #1257 (comment), to avoid an inevitable non-compliant hover colour of the two Docs links on the homepage, I have added an underline to them (they disappear on hover).
Edit: an alternative to the underline is to make the hover colour a not-ideal #000000 as in this previous preview:
https://graceful-manatee-d48970.netlify.app/
Edit Edit: these changes incorporate the unmerged changes made in #1257