Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor implementation to offer more customization #16

Merged
merged 2 commits into from
Mar 3, 2019

Conversation

zenangst
Copy link
Owner

@zenangst zenangst commented Mar 3, 2019

  • Add compare closure to the DiffManager for custom comparison.
  • Add Diffable protocol to override which value to use for diffing.

- Add `compare` closure to the `DiffManager` for custom comparison.
- Add `Diffable` protocol to override which value to use for diffing.
@codecov-io
Copy link

codecov-io commented Mar 3, 2019

Codecov Report

Merging #16 into master will increase coverage by 54.32%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #16       +/-   ##
===========================================
+ Coverage   32.51%   86.84%   +54.32%     
===========================================
  Files          13        9        -4     
  Lines         609      228      -381     
===========================================
  Hits          198      198               
+ Misses        411       30      -381
Impacted Files Coverage Δ
Source/Shared/DiffManager.swift 100% <100%> (ø) ⬆️
Source/Shared/Algorithm.swift 92.7% <100%> (+0.1%) ⬆️
...sts/iOS+tvOS/UICollectionViewExtensionsTests.swift
Tests/Shared/IndexPathManagerTests.swift
Tests/iOS+tvOS/UITableViewExtensionsTests.swift

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baca25f...78ce95a. Read the comment docs.

@zenangst zenangst merged commit 903f828 into master Mar 3, 2019
@zenangst zenangst deleted the feature/customizable-diffing branch March 3, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants