Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "unwindPath" option that enables data transformation prior to … #140

Merged
merged 2 commits into from
Sep 20, 2016

Conversation

jonathan-fulton
Copy link
Contributor

…writing CSV similar to MongoDB's $unwind operation

I've leveraged Lodash's cloneDeep function to minimize the amount of code change but it's slightly inefficient. Let me know what you think!

…writing CSV similar to MongoDB's $unwind operation
@coveralls
Copy link

coveralls commented Sep 15, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 33045bd on jonathan-fulton:master into ab3865d on zemirco:master.

@knownasilya knownasilya self-assigned this Sep 15, 2016
var fs = require('fs');
var fields = ['carModel', 'price', 'colors'];
var myCars = [
{ "carModel": "Audi", "price": 0, "colors": ["blue","green","yellow"] },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing that needs a fixup is the formatting on this array, and the extra spaces between fields.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along with quotes. Basically match the other example code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will make the change!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, pushed the change.

@knownasilya
Copy link
Collaborator

Related Issue: #139

@dciccale
Copy link

I would like to review the PR since I started the conversation, however it won't be possible till next Monday. If this is too much delay feel free to go ahead and continue without me. Otherwise would be good if you can leave it opened so I can also test it.

@knownasilya
Copy link
Collaborator

No problem

@coveralls
Copy link

coveralls commented Sep 16, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 1ae6ae1 on jonathan-fulton:master into ab3865d on zemirco:master.

@jonathan-fulton
Copy link
Contributor Author

@dciccale, did you have a chance to take a look yet?

@knownasilya
Copy link
Collaborator

I'll be merging this tomorrow, so let me know.

@dciccale
Copy link

yes, looks good!

@knownasilya knownasilya merged commit 6d14a8d into zemirco:master Sep 20, 2016
knownasilya pushed a commit that referenced this pull request Sep 20, 2016
- Add `unwindPath` feature, see #139, #140
@knownasilya
Copy link
Collaborator

Released as v3.7.0

@jonathan-fulton
Copy link
Contributor Author

Awesome, thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants