Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iQue] Match z_sram #2426

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[iQue] Match z_sram #2426

wants to merge 5 commits into from

Conversation

cadmic
Copy link
Contributor

@cadmic cadmic commented Jan 15, 2025

Notes:

  • A wild trigraph appeared! IDO interprets ??= as # but EGCS does not
  • I created SRAM_READ and SRAM_WRITE macros to wrap the iQue changes (thought this looked better than SRAM_READ_WRITE or something)
  • The checksum seems to match better as a struct. This is backed up by MM I think, idk why they would memcpy if it was a plain field: https://github.com/zeldaret/mm/blob/74266850b09ac865cb2a9e5f208a903f4b5ec44c/src/code/z_sram_NES.c#L933
  • This is one of the files affected by the EGCS bug, where some array members in structs don't work properly. I'm not sure there's a way to match both versions cleanly, I suspect the devs had to change the code to work around it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant