Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation pass centered on z_player_lib #1230

Merged
merged 2 commits into from
May 29, 2022

Conversation

Dragorn421
Copy link
Collaborator

  • Name a bunch of data lying in z_player_lib
  • For usage of arrays listed in sPlayerDListGroups (e.g. gPlayerLeftHandOpenDLs), consistently use pointer arithmetics instead of array indexing as the operations happen in an inconsistent order across code (+4,+age,+lodoffset,+shield*4,...), and arrays are 1D anyway
  • Name, comment, fixup various things in z_player_lib

Copy link
Collaborator

@Roman971 Roman971 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really not a fan of the array access changes since so much pointer arithmetic is a downgrade imo, even for the sake of consistency, but it's not a big deal either way

@fig02 fig02 merged commit d39ce02 into zeldaret:master May 29, 2022
@Dragorn421 Dragorn421 deleted the doc_player_1 branch May 29, 2022 20:34
louist103 pushed a commit to louist103/oot that referenced this pull request Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants