Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update weight templates to reflect weights-v2 #1109

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

Chralt98
Copy link
Member

@Chralt98 Chralt98 commented Sep 15, 2023

What does it do?

Fixes the templates to reflect the newest weight-v2. The information was taken from Acala here.

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

#1101

References

@Chralt98 Chralt98 added the s:review-needed The pull request requires reviews label Sep 15, 2023
@Chralt98 Chralt98 added this to the v0.4.1 milestone Sep 15, 2023
@Chralt98 Chralt98 self-assigned this Sep 15, 2023
@Chralt98 Chralt98 changed the title update weight templates to reflect weights-v2 Update weight templates to reflect weights-v2 Sep 15, 2023
Copy link
Member

@sea212 sea212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligns with paritytech/substrate#13475

In orml_weight_template and weight_template the range per component is missing (which was added to the frame weight template):

    {{#each benchmark.component_ranges as |range|}}
    /// The range of component `{{range.name}}` is `[{{range.min}}, {{range.max}}]`.
    {{/each}}

@Chralt98 Chralt98 requested a review from sea212 September 29, 2023 09:24
@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Sep 29, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (851c803) 93.53% compared to head (f41c524) 93.49%.
Report is 5 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1109      +/-   ##
==========================================
- Coverage   93.53%   93.49%   -0.04%     
==========================================
  Files          95       94       -1     
  Lines       29137    28645     -492     
==========================================
- Hits        27252    26783     -469     
+ Misses       1885     1862      -23     
Flag Coverage Δ
tests 93.49% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea212 sea212 merged commit a6777b9 into main Oct 3, 2023
@sea212 sea212 deleted the chralt98-fix-weights-to-v2 branch October 3, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants