forked from openedx/openedx-app-ios
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: [FC-0047] Full-Bleed Header + Top Navigation (openedx#385)
* feat: add course home header and upgrade ScrollSlidingTabBar * feat: remove old ui components from config file * feat: code review * test: add org value to CourseStructure models * style: adjust code formatting for consistency * feat: update collapsing logic to TopHeaderView * feat: add new icons and remove deprecated ones. Rename course to home * fix: correct missing commas in tests * fix: enhance UI consistency and resolve multiple bugs following product review * feat: fixes after code review * feat: fixes after @forgotvas code review * fix: move back button to default position
- Loading branch information
1 parent
a0c4c17
commit 0f7f1d4
Showing
55 changed files
with
1,030 additions
and
274 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 0 additions & 14 deletions
14
Core/Core/Assets.xcassets/CourseNavigationBar/book.circle.imageset/Frame.svg
This file was deleted.
Oops, something went wrong.
10 changes: 0 additions & 10 deletions
10
...ore/Assets.xcassets/CourseNavigationBar/bubble.left.circle.imageset/Frame-2.svg
This file was deleted.
Oops, something went wrong.
5 changes: 4 additions & 1 deletion
5
...bubble.left.circle.imageset/Contents.json → ...avigationBar/dates.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,15 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "Frame-2.svg", | ||
| "filename" : "dates.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| }, | ||
| "properties" : { | ||
| "template-rendering-intent" : "template" | ||
| } | ||
| } |
3 changes: 3 additions & 0 deletions
3
Core/Core/Assets.xcassets/CourseNavigationBar/dates.imageset/dates.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
15 changes: 15 additions & 0 deletions
15
Core/Core/Assets.xcassets/CourseNavigationBar/discussions.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "discussions.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| }, | ||
| "properties" : { | ||
| "template-rendering-intent" : "template" | ||
| } | ||
| } |
3 changes: 3 additions & 0 deletions
3
Core/Core/Assets.xcassets/CourseNavigationBar/discussions.imageset/discussions.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
14 changes: 0 additions & 14 deletions
14
Core/Core/Assets.xcassets/CourseNavigationBar/doc.circle.imageset/Frame-4.svg
This file was deleted.
Oops, something went wrong.
15 changes: 15 additions & 0 deletions
15
Core/Core/Assets.xcassets/CourseNavigationBar/downloads.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "downloads.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| }, | ||
| "properties" : { | ||
| "template-rendering-intent" : "template" | ||
| } | ||
| } |
3 changes: 3 additions & 0 deletions
3
Core/Core/Assets.xcassets/CourseNavigationBar/downloads.imageset/downloads.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 4 additions & 1 deletion
5
...ionBar/book.circle.imageset/Contents.json → ...NavigationBar/home.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,15 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "Frame.svg", | ||
| "filename" : "home.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| }, | ||
| "properties" : { | ||
| "template-rendering-intent" : "template" | ||
| } | ||
| } |
8 changes: 8 additions & 0 deletions
8
Core/Core/Assets.xcassets/CourseNavigationBar/home.imageset/home.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 4 additions & 1 deletion
5
...tionBar/doc.circle.imageset/Contents.json → ...NavigationBar/more.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,15 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "Frame-4.svg", | ||
| "filename" : "more.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| }, | ||
| "properties" : { | ||
| "template-rendering-intent" : "template" | ||
| } | ||
| } |
3 changes: 3 additions & 0 deletions
3
Core/Core/Assets.xcassets/CourseNavigationBar/more.imageset/more.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 0 additions & 11 deletions
11
Core/Core/Assets.xcassets/CourseNavigationBar/video.circle.imageset/Frame-3.svg
This file was deleted.
Oops, something went wrong.
5 changes: 4 additions & 1 deletion
5
...onBar/video.circle.imageset/Contents.json → ...vigationBar/videos.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,15 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "Frame-3.svg", | ||
| "filename" : "videos.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| }, | ||
| "properties" : { | ||
| "template-rendering-intent" : "template" | ||
| } | ||
| } |
3 changes: 3 additions & 0 deletions
3
Core/Core/Assets.xcassets/CourseNavigationBar/videos.imageset/videos.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.