Skip to content

Commit

Permalink
cfg80211: fix antenna gain handling
Browse files Browse the repository at this point in the history
No driver initializes chan->max_antenna_gain to something sensible, and
the only place where it is being used right now is inside ath9k. This
leads to ath9k potentially using less tx power than it can use, which can
decrease performance/range in some rare cases.

Rather than going through every single driver, this patch initializes
chan->orig_mag in wiphy_register(), ignoring whatever value the driver
left in there. If a driver for some reason wishes to limit it independent
from regulatory rulesets, it can do so internally.

Signed-off-by: Felix Fietkau <[email protected]>
Cc: [email protected]
Signed-off-by: Johannes Berg <[email protected]>
  • Loading branch information
Felix Fietkau authored and jmberg-intel committed Oct 18, 2012
1 parent 3a40414 commit c4a9faf
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions net/wireless/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -526,8 +526,7 @@ int wiphy_register(struct wiphy *wiphy)
for (i = 0; i < sband->n_channels; i++) {
sband->channels[i].orig_flags =
sband->channels[i].flags;
sband->channels[i].orig_mag =
sband->channels[i].max_antenna_gain;
sband->channels[i].orig_mag = INT_MAX;
sband->channels[i].orig_mpwr =
sband->channels[i].max_power;
sband->channels[i].band = band;
Expand Down

0 comments on commit c4a9faf

Please sign in to comment.