Stabilize Dart

[temeddix]

Summary

Fixes #49

• Added tests for Dart, just like Golang
  • Made bool check more strict
  • Fixed some parts that were reading container length as Int64, not Uint64: This wasn't a problem when the number is small(0x00000000~0x01111111), but was one of the problems that were causing the tests to fail
  • Made serialization/deserialization consider max bytes length
  • Made serialization/deserialization consider container depth
• Implemented sortMapEntries for BCS
• Bumped Dart versions in the CI and package config to 3.5.3(>=3.0.0, <4.0.0)

Test Plan

Since the tests were already defined in Golang, I've written some extra Dart tests that follows the way Golang does.

[ma2bd]

Thanks and congrats on the progress. Yes please would you be able to use the matcher package and keep the existing "complex map" test?

[temeddix]

The matcher package doesn't support comparing lists within tuples. I might need to write a custom comparison class that resembles matcher here.

[ma2bd]

The matcher package doesn't support comparing list in tuple. I might need to write a custom comparison class that resembles matcher here.

Maybe we can also disable this example for Dart.

[temeddix]

Okay :)

[ma2bd]

Thanks @temeddix. Perhaps @jerel would like to have a look at the Dart specific code?

[temeddix]

Hi, would it take some time to review?

[temeddix]

Hi @ma2bd @jerel, I was wondering if there are any updates regarding this PR. If it isn't planned to be merged into the main branch, I would appreciate a notice. Thank you!

[ma2bd]

Hi @ma2bd @jerel, I was wondering if there are any updates regarding this PR. If it isn't planned to be merged into the main branch, I would appreciate a notice. Thank you!

Hi @temeddix! Thanks for the reminder. I don't have any objection in principles. Let me have a look!

[ma2bd]

LGTM! Giving a few more days for @jerel to comment, then I'll land and make a release

[jerel]

This looks good to me, thanks for stabilizing the Dart implementation. I pulled this branch into one of my projects and all my tests are passing there so that seems good as well.

[ma2bd]

@temeddix @jerel Just released as part of serde-generate v0.28