Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated kubernetes deployment file #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated kubernetes deployment file #22

wants to merge 1 commit into from

Conversation

zeerorg
Copy link
Owner

@zeerorg zeerorg commented Nov 17, 2019

Updated extensions/v1beta1 to apps/v1beta1 for deployments

Signed-off-by: Rishabh Gupta(zeerorg) [email protected]

@zeerorg zeerorg mentioned this pull request Nov 17, 2019
@nyoung697
Copy link

I am testing this out on a new deployment of Kubernetes on DigitalOcean. (1.16.2-do.0)
I made the changes to the files as per this pull request.
I am getting a new error:

error: error validating "./yaml/kubernetes/connector-dep.yml": error validating data: ValidationError(Deployment.spec): missing required field "selector" in io.k8s.api.apps.v1.DeploymentSpec; if you choose to ignore these errors, turn validation off with --validate=false

What is supposed to be included in the selector field? I tried adding an empty field:

selector: {}

I then get the error:

The Deployment "sample-connector" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string(nil), MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: empty selector is invalid for deployment

@alexellis
Copy link
Contributor

It doesn't look like @zeerorg tested the change?

@alexellis
Copy link
Contributor

@nyoung697 please track the issue I linked above. I've forked this project so that we can make changes as needed. @zeerorg you're welcome to merge them back to your repo and to send us PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants