Fix broken f-string in error output #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default formatting rules build into ruff seem to work well enough for us, so we make no adjustments.
awelzel
reviewed
Dec 9, 2024
awelzel
reviewed
Dec 9, 2024
awelzel
reviewed
Dec 9, 2024
awelzel
approved these changes
Dec 9, 2024
bbannier
force-pushed
the
topic/bbannier/fix-error-message
branch
from
9d1a5f0 to
fed4496
Compare
This patch switches to ruff from pylint. We migrate a few suppressions from pylint's suppression format to the more general format used by ruff. Additionally we fix a few issues, e.g., around import sorting and globbing, shadowing, unnecessary import hacks for test imports and general style.
bbannier
force-pushed
the
topic/bbannier/fix-error-message
branch
from
fed4496 to
c378bd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the fix for the error message I pilled on a number of cleanups I had sitting around. I can move these to a separate PR if needed.