Skip to content

Commit

Permalink
Fix race in project Makefile
Browse files Browse the repository at this point in the history
The Makefile did not work correctly when used with `-jN` with `N>1`
since `test` did not declare its dependency on `build`.

This patch makes that dependency explicit, and also declares `build` as
PHONY so it is always run.
  • Loading branch information
bbannier committed Sep 22, 2023
1 parent 48f25b2 commit 11f63bf
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
all: build test
.PHONY: build test

all: test

build:
python setup.py build

test:
test: build
cd tests && python -m unittest

0 comments on commit 11f63bf

Please sign in to comment.