Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for RTD. #1041

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Fix build for RTD. #1041

merged 1 commit into from
Nov 4, 2021

Conversation

bbannier
Copy link
Member

@bbannier bbannier commented Nov 4, 2021

This resolves the build problems due to sphinx-doc/sphinx#9727 we've
been seeing.

@bbannier bbannier self-assigned this Nov 4, 2021
@bbannier
Copy link
Member Author

bbannier commented Nov 4, 2021

This PR adapts the changes from zeek/package-manager#126 for Spicy where we have seen similar problems.

@bbannier bbannier force-pushed the topic/bbannier/bump-sphinx-for-rtd branch from b7596a5 to 82dd537 Compare November 4, 2021 08:32
@bbannier bbannier changed the title Request at least Sphinx 2.0 to avoid a dependency problem in RTD. Fix build for RTD. Nov 4, 2021
@bbannier bbannier marked this pull request as ready for review November 4, 2021 11:37
@bbannier bbannier requested a review from rsmmr November 4, 2021 11:37
rsmmr
rsmmr previously approved these changes Nov 4, 2021
This resolves the build problems due to sphinx-doc/sphinx#9727 we've
been seeing. RTD seems to by default run a <sphinx-2.0 which conflicts
with newer docutils.

Since we usually install sphinx from the system for building the docs
instead pin docutils in the docs requirements file which is parsed by
RTD.
@bbannier bbannier force-pushed the topic/bbannier/bump-sphinx-for-rtd branch from 9a82226 to 616b8c1 Compare November 4, 2021 12:04
@bbannier bbannier merged commit 1b04773 into main Nov 4, 2021
@bbannier bbannier deleted the topic/bbannier/bump-sphinx-for-rtd branch November 4, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants