Encapsulate all commands #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new functions to always create new commands, such that we not reuse commands and not rely on globals
ChrisKujawa
force-pushed
the
zell-new-cmds
branch
from
aec1dba to
010466d
Compare
Move the properties namespace and kubeconfig in a scoped flags obj, which is always recreated when executing workers
|
@oleschoenburg with the last commit I was also able to move the namespace and kubeconfig to the flags struct |
lenaschoenburg
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to not run into issues with global variables reused and reset during worker execute, we encapsulated all commands and make it available via
NewCMDso everytime we have to create a new command to execute zbchaos in the workers.This allows us to always use a clean context.