Migrate worker restart experiment #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In self-managed env the zeebe gateway service is called differently, based on the helm release name. The release name is in our setups normally also the namespace name, which we use here. If the worker is already deployed we update the deployment, instead of failing. Added missing tests for it.
|
I will go ahead and merge it, but please have a look if you have time and if you see anything weird just ping me. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First fixed an issue with the worker deployments:
In self-managed env the zeebe gateway service is called differently, based on the helm release name.
The release name is in our setups normally also the namespace name, which we use here.
If the worker is already deployed we update the deployment, instead of failing.
Migrated the worker restart experiment related to #237
Similar to the other migrated experiments I followed same approach as described here #268
This is btw the LAST production s experiment to migrate 🎉