Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: file dialogs #7852

Merged
merged 5 commits into from
Feb 16, 2024
Merged

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Feb 15, 2024

This PR implements linux file dialogs and open/reveal actions.

Open folder Reveal path
Screenshot from 2024-02-15 16-50-49 Screenshot from 2024-02-15 16-51-36

Copy link

cla-bot bot commented Feb 15, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @romgrk on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@Titaniumtown Titaniumtown mentioned this pull request Feb 15, 2024
12 tasks
@mikayla-maki mikayla-maki self-assigned this Feb 15, 2024
@Eiji7
Copy link

Eiji7 commented Feb 15, 2024

Sorry if it's wrong place to ask, but I just found your PR and would like to know if the design is already decided. If not I would like to ask about support for ~/.local/share/user-places.xbel and similar files. KDE Plasma in this example have a XML file from which we can fetch an information about:

  1. User directories (home, documents, downloads etc.)
  2. Block devices like USB drives or partitions
  3. Network places
  4. Recently used

Having support for all user places regardless of used Desktop Environment would be definitely a great addition.

Here is an example screenshot from a Dolphin app.

@romgrk
Copy link
Contributor Author

romgrk commented Feb 15, 2024

The xdg-desktop-portal backend would handle those concerns.

@romgrk romgrk force-pushed the feat-linux-file-dialogs branch from 63b4f93 to 597a808 Compare February 15, 2024 21:49
Copy link

cla-bot bot commented Feb 15, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @romgrk on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@romgrk romgrk force-pushed the feat-linux-file-dialogs branch from 597a808 to 5584d5d Compare February 15, 2024 21:54
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 15, 2024
@romgrk romgrk force-pushed the feat-linux-file-dialogs branch from 5584d5d to 073e300 Compare February 15, 2024 21:55
Copy link

cla-bot bot commented Feb 16, 2024

The cla-bot has been summoned, and re-checked this pull request!

@romgrk romgrk marked this pull request as ready for review February 16, 2024 14:07
Copy link
Member

@mikayla-maki mikayla-maki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@mikayla-maki mikayla-maki merged commit bea3691 into zed-industries:main Feb 16, 2024
6 checks passed
@romgrk romgrk deleted the feat-linux-file-dialogs branch February 16, 2024 19:05
@Sergekarr
Copy link

@cla-bot check

Copy link

cla-bot bot commented Mar 4, 2024

The cla-bot has been summoned, and re-checked this pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants