Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux port via Blade #7343

Merged
merged 53 commits into from
Feb 7, 2024
Merged

Linux port via Blade #7343

merged 53 commits into from
Feb 7, 2024

Conversation

kvark
Copy link
Contributor

@kvark kvark commented Feb 3, 2024 •
edited by mikayla-maki
Loading

Motivation

I ❤️ Zed! It's lightning fast and has great UX. I want it to run as well on all major platforms. I'm currently using Linux most actively.
Blade is a good candidate for providing GPU access: it supports Vulkan, Metal, and GLES/WebGL. Its abstraction is extremely thin, while having one of the nicest GPU APIs. Codebase is also tiny. Checkout the meetup recording from a year ago.
I believe these projects make a good match 🚀 !

Why this is a bad idea

If Zed team wants to use off-the-shelf components from Rust ecosystem, then Blade is certainly at disadvantage here, since it's not widely used. It would rely on Zed team adding necessary features in a branch, then maybe upstreaming some of them. That is to say, it's unclear if this can be avoided with more popular alternatives - being flexible with any local changes is a good ability.

Why it's not too bad

Blade uses WGSL shaders, similar to wgpu and arcana, but without the binding decorations. So this aspect of the product is nicely portable.

Progress

  • Platforms
    • X11 (via xcb)
      • input handling
      • get proper content size
    • Windows
    • Replace the existing Metal backend
  • Text System
    • shaping
    • glyph rasterization
  • Texture atlas
  • Rendering
    • basic primitives
    • path rendering
    • sprite rendering
  • media surfaces
  • CI

Current status

Zed starts up but crashes on text-system related checks.
zed-linux-1

kvark added 23 commits February 1, 2024 21:27
@kvark
Add blade dependency
ef4ef5f
@kvark
Add Linux platform, gate usage of CVImageBuffer by macOS
d675abf
@kvark
linux: implement dispatcher, add dummy textsystem
ca62d22
@kvark
linux: start the text system
b0376aa
@kvark
linux: basic window, display, and atlas
e95bf24
@kvark
linux: hook up X11rb for Window creation
cefc982
@kvark
x11: create window and route events
aed363d
@kvark
linux: port from x11rb to xcb and hook up RawWindowHandle
7f8c64a
@kvark
linux: hook up render event, basic renderer command buffer
74fde59
@kvark
linux: work around the mutex locks for request_frame and resize
503ac7a
@kvark
linux: basic quad renderer logic
8aa7687
@kvark
hide MacOS dependencie of live_kit_client and media
ecf4955
@kvark
linux: shadow rendering
666b134
@kvark
linux: share corner picking code between shaders
c9ec337
@kvark
linux: refactor window structure, support move callback
ce84a2a
@kvark
WIP path rasterization
ed679c9
@kvark
linux: implement RWH for LinuxWindow
05c4221
@kvark
linux: path rasterization shader
fdaffdb
@kvark
blade: path sprite rendering
c000d2e
@kvark
blade: refactor the atlas to not own the command encoder
04e49dc
@kvark
blade: port underline shader
7c7aad5
@kvark
linux: various fixes across the crates to make it compile
2e32f58
@kvark
blade: point to master, remove the override
59642bf
@cla-bot cla-bot
Copy link

cla-bot bot commented Feb 3, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @kvark on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@kvark kvark marked this pull request as draft February 3, 2024 22:29
@kvark
Copy link
Contributor Author

kvark commented Feb 3, 2024

@cla-bot check

@cla-bot cla-bot
Copy link

cla-bot bot commented Feb 3, 2024

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 3, 2024
@kvark
Copy link
Contributor Author

kvark commented Feb 6, 2024

@williamdes yes, that's the big boss of the text system missing. Looks like the suggested path to it is implementing cosmic_text.

@williamdes
Copy link
Contributor

I do not know where 7509677 comes from but:

/cc @mikayla-maki
The packages in the commit do not exist on Debian 12

@h3mosphere
Copy link
Contributor

@aminya: Can you try the following branch: https://github.com/h3mosphere/zed/tree/resize-on-draw

I had the same issue, this is probably a performance killer until @kvark can work out a better solution. But it works for me.

After kvark#2, I also get a white screen for a second. This is the error I get then resulting in a crash:

@aminya
Copy link
Contributor

aminya commented Feb 6, 2024 •
edited
Loading

I do not know where 7509677 comes from but:

/cc @mikayla-maki The packages in the commit do not exist on Debian 12

It reverted it in kvark#2. cause it also causes conflicts.
@mikayla-maki was this commit intended? If so, could you create pull requests instead of directly pushing?

@bhavya3024
Copy link

do we have support for linux if this PR gets merged ?

@mikayla-maki
Copy link
Member

@aminya, sorry about that meant to push to a branch. Thanks for fixing things :)

@noverby
Copy link

noverby commented Feb 6, 2024

@bhavya3024 No, there is still missing essential functionality. E.g. font rendering.

aminya and others added 2 commits February 6, 2024 22:54
@aminya
Fixes for file-watching, user assets, and system dependencies (#2)
d3562d4 
* fix: avoid panics in case of non-existing path for watching

* fix: copy the themes and plugins

* Revert "add a few more libraries to the linux script"

This reverts commit 7509677.

* fix: add vulkan validation layers to the system deps

* fix: fix the themes paths
@kvark
linux: query window geometry for determining the surface extents
e3ae7c4
@bhavya3024
Copy link

@noverby ok, waiting for the day when I can have this as an alternative to vscode.

@mikayla-maki mikayla-maki marked this pull request as ready for review February 7, 2024 19:53
@mikayla-maki mikayla-maki mentioned this pull request Feb 7, 2024
Closed
12 tasks
@mikayla-maki mikayla-maki changed the title [unofficial] Linux port via Blade [official] Linux port via Blade Feb 7, 2024
@mikayla-maki mikayla-maki merged commit 5ded865 into zed-industries:main Feb 7, 2024
5 checks passed
@mikayla-maki mikayla-maki changed the title [official] Linux port via Blade Linux port via Blade Feb 7, 2024
@kvark kvark deleted the blade branch February 10, 2024 23:36
@RustoMCSpit
Copy link

Zed team wants to use off-the-shelf components from Rust ecosystem, then Blade is certainly at disadvantage here, since it's not widely used. It would rely on Zed team adding necessary features in a branch, then maybe upstreaming some of them.

they could also just offer its developer a full-time, work-at-home job as theyre more proficient with linux and they could then gear blade into its direction rather than other way round. just throwing the idea out there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminya aminya aminya requested changes

@istudyatuni istudyatuni istudyatuni left review comments

Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.