Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: Use nix-systems to provide the needed systems as flake inputs #21443

Closed
wants to merge 1 commit into from

Conversation

xtrm-en
Copy link
Contributor

@xtrm-en xtrm-en commented Dec 3, 2024

This change allows flake consumers to override the systems input to provide only the necessary output, instead of every system possible. See the nix-systems project.

$ nix flake show --override-input systems github:nix-systems/x86_64-linux
• Updated input 'systems':
    'github:nix-systems/default/da67096a3b9bf56a91d16901293e51ba5b49a27e?narHash=sha256-Vy1rq5AaRuLzOxct8nz4T6wlgyUR7zLU309k9mBC768%3D' (2023-04-09)
  → 'github:nix-systems/x86_64-linux/2ecfcac5e15790ba6ce360ceccddb15ad16d08a8?narHash=sha256-Gtqg8b/v49BFDpDetjclCYXm8mAnTrUzR0JnE2nv5aw%3D' (2023-04-08)
git+file:///home/x/Work/@me/zed
├───devShells
│   └───x86_64-linux
│       └───default: development environment 'nix-shell'
├───formatter
│   └───x86_64-linux: package 'nixfmt-unstable-2024-11-26'
├───overlays
│   ├───default: Nixpkgs overlay
│   ├───rust-overlay: Nixpkgs overlay
│   ├───rust-toolchain: Nixpkgs overlay
│   └───zed-editor: Nixpkgs overlay
└───packages
    └───x86_64-linux
        ├───default: package 'zed-editor-nightly'
        └───zed-editor: package 'zed-editor-nightly'

This PR also updates the flake inputs to their latest versions.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 3, 2024
@mikayla-maki
Copy link
Contributor

mikayla-maki commented Dec 5, 2024

It seems that this pattern is somewhat controversial: NixOS/nix#3843 (comment). And I don't think we want to add speculative features to our flake, particularly as not many of us use nix ourselves.

Caveat: I'm not a nix person and I don't know what's going on in y'alls community. Please let me know if this is incorrect :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants