Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintain iOS 15 compatibility #64

Closed
pacu opened this issue Sep 2, 2024 · 0 comments · Fixed by #65
Closed

maintain iOS 15 compatibility #64

pacu opened this issue Sep 2, 2024 · 0 comments · Fixed by #65
Assignees
@pacu

Comments

@pacu
Copy link
Collaborator

pacu commented Sep 2, 2024

from @LukasKorba :

Hi Pacu, it's been a while since I implemented request zec and zip321 payment uri
seems like .product(name: "BigDecimal", package: "BigDecimal"),
is dependent on .package(url: "https://github.com/mgriebling/BigInt.git", from: "2.0.0"),
and BigInt is set to deployment target ios 16.4 while zashi is ios 15.0
do you think we can somehow resolve that?

the reason behind using big decimal is because of getting a lof of bugs from the Decimal implementation on Swift.

I guess we can temporarily fix zip-321 package to lock this dependency
@pacu pacu self-assigned this Sep 2, 2024
pacu added a commit that referenced this issue Sep 2, 2024
@pacu
[#64] maintain iOS 15 compatibility
3e5d89c 
closes #64

Lukas Korba from ECC reported that Zashi couldn't be built since
the latest version of BigDecimal depend on BigInt which has min
deployment target of iOS 16.4
@pacu pacu mentioned this issue Sep 2, 2024
Merged
@pacu pacu moved this to In Progress in Z Dev Rel Engineer Sep 2, 2024
pacu added a commit that referenced this issue Sep 3, 2024
@pacu
Merge pull request #65 from pacu/maintain-ios-15-compatibility
720a73a 
[#64] maintain iOS 15 compatibility
@pacu pacu closed this as completed in #65 Sep 3, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Z Dev Rel Engineer Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pacu pacu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#64] maintain iOS 15 compatibility zecdev/zcash-swift-payment-uri
1 participant
@pacu