Dockerized + Testing with TravisCI #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@centsent I used the golang:alpine image, which is the same like using alpine and then installing go. Size and time spent was also the same - is this ok for you? |
|
I decided against the travis go environment and switched back using docker-compose in Travis because we would have to manage/define a mongodb service in multiple files. The pro argument would be, that we could test multiple versions of go for each test run. But lets start easy.. If anything is missing please reopen this or start a new PR :) Thanks! |
|
One more note: with support of custom DialInfo as config attribute, I renamed |
|
Well done, it's ok for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@centsent I doubled the PR because it was easier to append my changes - we have to get this done ;)