Inline nested tags support #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the work. I enabled tests for your PR. |
|
Yeah sure. I believe these were failing before I started working on the grammar but I'll have a look into them soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @zealot128, I've had a go at adding support for nested pug syntax (I.e.:
div A #[a(href="/link") link] can go here.) as it's one of a few things I've noticed needs sorting whilst using the parser and I saw the TODO at the top ofgrammar.js. I appreciate this looks like a big pull request, but all I've really done is:grammar.jstest/example.pugtest/corpus/inline-nested.txtAside from that most of the files were generated on
tree-sitter generate. I've noticed however that these files also exist in other treesitter parser repositories that are marked as "complete", so I've committed them and updated the.gitignoreto match some of these other "complete" parsers.From what I can see it seems to be working fine. The tests pass and I can see the highlighting working in the example file locally. Let me know if I've missed anything here or done anything wrong, it's my first attempt at a treesitter parser and I have had a few other minor issues whilst using this one that I intend to fix once I know you're happy with what's been done so far.