Background fix for dark mode #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If HTML page doesn't set background ("Bash" docset for example) then it will be
theme-dependent. When light theme is used with disabled dark mode everything works well -
we have black text on white background. When light theme is used with enabled dark mode
everything is fine again - we have light text on dark background. But when dark theme is
used with disabled dark mode we will see black text on dark background (tested on Qt 5.11).
Therefore when our dark mode CSS is applied we will see light text on light background :(
So we should always set default background color to white - it will be properly processed
both for light and dark themes.
|
Thanks for contributing! I am not sure though that it's a good idea to override background by default. |
|
I guess we should give this a go, and see if any docsets will break. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If HTML page doesn't set background ("Bash" docset for example) then it will be theme-dependent. When light theme is used with disabled dark mode everything works well - we have black text on white background. When light theme is used with enabled dark mode everything is fine again - we have light text on dark background. But when dark theme is used with disabled dark mode we will see black text on dark background (tested on Qt 5.11). Therefore when our dark mode CSS is applied we will see light text on light background :( So we should always set default background color to white - it will be properly processed both for light and dark themes.
OLD version:
NEW version:
