Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include type information in panic messages #201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nikpivkin
Copy link

This PR enriches the panic message by adding type information, which will make debugging easier.

@apparentlymart
Copy link
Collaborator

Thanks for working on this @nikpivkin.

The two panic messages you have changed here should be completely unreachable unless there is a bug in cty. Did you find a situation where those panics would occur when you called those functions with specific input? If so, I'd prefer to fix the bug that allowed this to panic than to change the panic messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants