ZIP 244: Clarify contruction of hashAuthDataRoot
#520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
force-pushed
the
zip244-clarify_auth_tree
branch
from
2f7ea0c to
5f67eda
Compare
2 tasks
This changes the specification of hashAuthDataRoot to state that leaves of the Merkle tree used to construct hashAuthDataRoot should have the null hash value, while empty internal nodes should be hashes of empty leaves. It also defines an all-FFs placeholder value to be used for pre-v5 transactions in this tree. Co-authored-by: Kris Nuttycom <[email protected]> Co-authored-by: Jack Grigg <[email protected]> Signed-off-by: Daira Hopwood <[email protected]>
daira
force-pushed
the
zip244-clarify_auth_tree
branch
from
5f67eda to
f0c438d
Compare
nuttycom
added a commit
to nuttycom/zcash
that referenced
this pull request
Jun 15, 2021
As specified in zcash/zips#520 Fixes zcash#5218
Signed-off-by: Daira Hopwood <[email protected]>
daira
force-pushed
the
zip244-clarify_auth_tree
branch
from
4bc4eee to
604c40a
Compare
nuttycom
commented
Jun 15, 2021
daira
changed the title
hashAuthDataRoothashAuthDataRoot
str4d
approved these changes
Jun 16, 2021
Comment on lines
+603
to
+605
| For transaction versions before v5, a placeholder value consisting of 32 bytes of | ||
| ``0xFF`` is used in place of the authorizing data commitment. This is only used in | ||
| the tree committed to by ``hashAuthDataRoot``, as defined in `Block Header Changes`_. |
There was a problem hiding this comment.
I don't personally think this separation is necessary, as it only helps the hashAuthDataRoot to commit to the exact number of transactions in the block, but that commitment has no value on its own, and hashMerkleRoot already commits to the number of transactions in the block. However, I don't see any harm in doing this, and once v4 transactions are removed from consensus in a future NU, it won't matter anymore.
I checked that v4 transactions are prohibited from the wider ZIP 239 network messages, so the "only used" wording here is correct.
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Jun 16, 2021
Update transaction auth commitments for pre-v5 transactions. As specified in zcash/zips#520 Fixes #5218
Mr-Bossman
pushed a commit
to Mr-Bossman/VerusCoin
that referenced
this pull request
Aug 26, 2021
As specified in zcash/zips#520 Fixes zcash#5218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the specification of
hashAuthDataRootto state that leaves of the Merkle tree used to constructhashAuthDataRootshould have the null hash value, while empty internal nodes should be hashes of empty leaves.Fixes #519